Bug Summary

File:src/usr.bin/openssl/dsaparam.c
Warning:line 336, column 4
Value stored to 'i' is never read

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.4 -analyze -disable-free -clear-ast-before-backend -disable-llvm-verifier -discard-value-names -main-file-name dsaparam.c -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/usr.bin/openssl/obj -resource-dir /usr/local/llvm16/lib/clang/16 -D LIBRESSL_INTERNAL -internal-isystem /usr/local/llvm16/lib/clang/16/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/usr.bin/openssl/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fcf-protection=branch -fno-jump-tables -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/scan/2024-01-11-140451-98009-1 -x c /usr/src/usr.bin/openssl/dsaparam.c
1/* $OpenBSD: dsaparam.c,v 1.15 2023/03/06 14:32:06 tb Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved.
4 *
5 * This package is an SSL implementation written
6 * by Eric Young (eay@cryptsoft.com).
7 * The implementation was written so as to conform with Netscapes SSL.
8 *
9 * This library is free for commercial and non-commercial use as long as
10 * the following conditions are aheared to. The following conditions
11 * apply to all code found in this distribution, be it the RC4, RSA,
12 * lhash, DES, etc., code; not just the SSL code. The SSL documentation
13 * included with this distribution is covered by the same copyright terms
14 * except that the holder is Tim Hudson (tjh@cryptsoft.com).
15 *
16 * Copyright remains Eric Young's, and as such any Copyright notices in
17 * the code are not to be removed.
18 * If this package is used in a product, Eric Young should be given attribution
19 * as the author of the parts of the library used.
20 * This can be in the form of a textual message at program startup or
21 * in documentation (online or textual) provided with the package.
22 *
23 * Redistribution and use in source and binary forms, with or without
24 * modification, are permitted provided that the following conditions
25 * are met:
26 * 1. Redistributions of source code must retain the copyright
27 * notice, this list of conditions and the following disclaimer.
28 * 2. Redistributions in binary form must reproduce the above copyright
29 * notice, this list of conditions and the following disclaimer in the
30 * documentation and/or other materials provided with the distribution.
31 * 3. All advertising materials mentioning features or use of this software
32 * must display the following acknowledgement:
33 * "This product includes cryptographic software written by
34 * Eric Young (eay@cryptsoft.com)"
35 * The word 'cryptographic' can be left out if the rouines from the library
36 * being used are not cryptographic related :-).
37 * 4. If you include any Windows specific code (or a derivative thereof) from
38 * the apps directory (application code) you must include an acknowledgement:
39 * "This product includes software written by Tim Hudson (tjh@cryptsoft.com)"
40 *
41 * THIS SOFTWARE IS PROVIDED BY ERIC YOUNG ``AS IS'' AND
42 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
43 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
44 * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE
45 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
46 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
47 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
48 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
49 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
50 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
51 * SUCH DAMAGE.
52 *
53 * The licence and distribution terms for any publically available version or
54 * derivative of this code cannot be changed. i.e. this code cannot simply be
55 * copied and put under another distribution licence
56 * [including the GNU Public Licence.]
57 */
58
59#include <openssl/opensslconf.h> /* for OPENSSL_NO_DSA */
60
61/* Until the key-gen callbacks are modified to use newer prototypes, we allow
62 * deprecated functions for openssl-internal code */
63#ifdef OPENSSL_NO_DEPRECATED
64#undef OPENSSL_NO_DEPRECATED
65#endif
66
67#include <limits.h>
68#include <stdio.h>
69#include <stdlib.h>
70#include <string.h>
71#include <time.h>
72
73#include "apps.h"
74
75#include <openssl/bio.h>
76#include <openssl/bn.h>
77#include <openssl/err.h>
78#include <openssl/dsa.h>
79#include <openssl/pem.h>
80#include <openssl/x509.h>
81
82static struct {
83 int C;
84 int genkey;
85 char *infile;
86 int informat;
87 int noout;
88 char *outfile;
89 int outformat;
90 int text;
91} cfg;
92
93static const struct option dsaparam_options[] = {
94 {
95 .name = "C",
96 .desc = "Convert DSA parameters into C code",
97 .type = OPTION_FLAG,
98 .opt.flag = &cfg.C,
99 },
100 {
101 .name = "genkey",
102 .desc = "Generate a DSA key",
103 .type = OPTION_FLAG,
104 .opt.flag = &cfg.genkey,
105 },
106 {
107 .name = "in",
108 .argname = "file",
109 .desc = "Input file (default stdin)",
110 .type = OPTION_ARG,
111 .opt.arg = &cfg.infile,
112 },
113 {
114 .name = "inform",
115 .argname = "format",
116 .desc = "Input format (DER or PEM (default))",
117 .type = OPTION_ARG_FORMAT,
118 .opt.value = &cfg.informat,
119 },
120 {
121 .name = "noout",
122 .desc = "No output",
123 .type = OPTION_FLAG,
124 .opt.flag = &cfg.noout,
125 },
126 {
127 .name = "out",
128 .argname = "file",
129 .desc = "Output file (default stdout)",
130 .type = OPTION_ARG,
131 .opt.arg = &cfg.outfile,
132 },
133 {
134 .name = "outform",
135 .argname = "format",
136 .desc = "Output format (DER or PEM (default))",
137 .type = OPTION_ARG_FORMAT,
138 .opt.value = &cfg.outformat,
139 },
140 {
141 .name = "text",
142 .desc = "Print as text",
143 .type = OPTION_FLAG,
144 .opt.flag = &cfg.text,
145 },
146 { NULL((void *)0) },
147};
148
149static void
150dsaparam_usage(void)
151{
152 fprintf(stderr(&__sF[2]),
153 "usage: dsaparam [-C] [-genkey] [-in file]\n"
154 " [-inform format] [-noout] [-out file] [-outform format]\n"
155 " [-text] [numbits]\n\n");
156 options_usage(dsaparam_options);
157}
158
159static int dsa_cb(int p, int n, BN_GENCB *cb);
160
161int
162dsaparam_main(int argc, char **argv)
163{
164 DSA *dsa = NULL((void *)0);
165 int i;
166 BIO *in = NULL((void *)0), *out = NULL((void *)0);
167 BN_GENCB *cb = NULL((void *)0);
168 int ret = 1;
169 int numbits = -1;
170 char *strbits = NULL((void *)0);
171
172 if (pledge("stdio cpath wpath rpath", NULL((void *)0)) == -1) {
173 perror("pledge");
174 exit(1);
175 }
176
177 memset(&cfg, 0, sizeof(cfg));
178
179 cfg.informat = FORMAT_PEM3;
180 cfg.outformat = FORMAT_PEM3;
181
182 if (options_parse(argc, argv, dsaparam_options, &strbits, NULL((void *)0)) != 0) {
183 dsaparam_usage();
184 goto end;
185 }
186
187 if (strbits != NULL((void *)0)) {
188 const char *errstr;
189 numbits = strtonum(strbits, 0, INT_MAX0x7fffffff, &errstr);
190 if (errstr) {
191 fprintf(stderr(&__sF[2]), "Invalid number of bits: %s", errstr);
192 goto end;
193 }
194 }
195
196 in = BIO_new(BIO_s_file());
197 out = BIO_new(BIO_s_file());
198 if (in == NULL((void *)0) || out == NULL((void *)0)) {
199 ERR_print_errors(bio_err);
200 goto end;
201 }
202 if (cfg.infile == NULL((void *)0))
203 BIO_set_fp(in, stdin, BIO_NOCLOSE)BIO_ctrl(in,106,0x00,(char *)(&__sF[0]));
204 else {
205 if (BIO_read_filename(in, cfg.infile)BIO_ctrl(in,108, 0x01|0x02,(char *)cfg.infile) <= 0) {
206 perror(cfg.infile);
207 goto end;
208 }
209 }
210 if (cfg.outfile == NULL((void *)0)) {
211 BIO_set_fp(out, stdout, BIO_NOCLOSE)BIO_ctrl(out,106,0x00,(char *)(&__sF[1]));
212 } else {
213 if (BIO_write_filename(out, cfg.outfile)BIO_ctrl(out,108, 0x01|0x04,cfg.outfile) <= 0) {
214 perror(cfg.outfile);
215 goto end;
216 }
217 }
218
219 if (numbits > 0) {
220 if ((cb = BN_GENCB_new()) == NULL((void *)0)) {
221 BIO_printf(bio_err,
222 "Error allocating BN_GENCB object\n");
223 goto end;
224 }
225
226 BN_GENCB_set(cb, dsa_cb, bio_err);
227
228 dsa = DSA_new();
229 if (!dsa) {
230 BIO_printf(bio_err, "Error allocating DSA object\n");
231 goto end;
232 }
233 BIO_printf(bio_err, "Generating DSA parameters, %d bit long prime\n", numbits);
234 BIO_printf(bio_err, "This could take some time\n");
235 if (!DSA_generate_parameters_ex(dsa, numbits, NULL((void *)0), 0, NULL((void *)0), NULL((void *)0), cb)) {
236 ERR_print_errors(bio_err);
237 BIO_printf(bio_err, "Error, DSA key generation failed\n");
238 goto end;
239 }
240 } else if (cfg.informat == FORMAT_ASN11)
241 dsa = d2i_DSAparams_bio(in, NULL((void *)0));
242 else if (cfg.informat == FORMAT_PEM3)
243 dsa = PEM_read_bio_DSAparams(in, NULL((void *)0), NULL((void *)0), NULL((void *)0));
244 else {
245 BIO_printf(bio_err, "bad input format specified\n");
246 goto end;
247 }
248 if (dsa == NULL((void *)0)) {
249 BIO_printf(bio_err, "unable to load DSA parameters\n");
250 ERR_print_errors(bio_err);
251 goto end;
252 }
253 if (cfg.text) {
254 DSAparams_print(out, dsa);
255 }
256 if (cfg.C) {
257 unsigned char *data;
258 int l, len, bits_p;
259
260 len = BN_num_bytes(DSA_get0_p(dsa))((BN_num_bits(DSA_get0_p(dsa))+7)/8);
261 bits_p = BN_num_bits(DSA_get0_p(dsa));
262 data = malloc(len + 20);
263 if (data == NULL((void *)0)) {
264 perror("malloc");
265 goto end;
266 }
267 l = BN_bn2bin(DSA_get0_p(dsa), data);
268 printf("static unsigned char dsa%d_p[] = {", bits_p);
269 for (i = 0; i < l; i++) {
270 if ((i % 12) == 0)
271 printf("\n\t");
272 printf("0x%02X, ", data[i]);
273 }
274 printf("\n\t};\n");
275
276 l = BN_bn2bin(DSA_get0_q(dsa), data);
277 printf("static unsigned char dsa%d_q[] = {", bits_p);
278 for (i = 0; i < l; i++) {
279 if ((i % 12) == 0)
280 printf("\n\t");
281 printf("0x%02X, ", data[i]);
282 }
283 printf("\n\t};\n");
284
285 l = BN_bn2bin(DSA_get0_g(dsa), data);
286 printf("static unsigned char dsa%d_g[] = {", bits_p);
287 for (i = 0; i < l; i++) {
288 if ((i % 12) == 0)
289 printf("\n\t");
290 printf("0x%02X, ", data[i]);
291 }
292 free(data);
293 printf("\n\t};\n\n");
294
295 printf("DSA *get_dsa%d()\n\t{\n", bits_p);
296 printf("\tBIGNUM *p = NULL, *q = NULL, *g = NULL;\n");
297 printf("\tDSA *dsa;\n\n");
298 printf("\tif ((dsa = DSA_new()) == NULL) return(NULL);\n");
299 printf("\tp = BN_bin2bn(dsa%d_p, sizeof(dsa%d_p), NULL);\n",
300 bits_p, bits_p);
301 printf("\tq = BN_bin2bn(dsa%d_q, sizeof(dsa%d_q), NULL);\n",
302 bits_p, bits_p);
303 printf("\tg = BN_bin2bn(dsa%d_g, sizeof(dsa%d_g), NULL);\n",
304 bits_p, bits_p);
305 printf("\tif (p == NULL || q == NULL || g == NULL)\n");
306 printf("\t\t{ BN_free(p); BN_free(q); BN_free(g); DSA_free(dsa); return(NULL); }\n");
307 printf("\tDSA_set0_pqg(dsa, p, q, g);\n");
308 printf("\treturn(dsa);\n\t}\n");
309 }
310 if (!cfg.noout) {
311 if (cfg.outformat == FORMAT_ASN11)
312 i = i2d_DSAparams_bio(out, dsa);
313 else if (cfg.outformat == FORMAT_PEM3)
314 i = PEM_write_bio_DSAparams(out, dsa);
315 else {
316 BIO_printf(bio_err, "bad output format specified for outfile\n");
317 goto end;
318 }
319 if (!i) {
320 BIO_printf(bio_err, "unable to write DSA parameters\n");
321 ERR_print_errors(bio_err);
322 goto end;
323 }
324 }
325 if (cfg.genkey) {
326 DSA *dsakey;
327
328 if ((dsakey = DSAparams_dup(dsa)) == NULL((void *)0))
329 goto end;
330 if (!DSA_generate_key(dsakey)) {
331 ERR_print_errors(bio_err);
332 DSA_free(dsakey);
333 goto end;
334 }
335 if (cfg.outformat == FORMAT_ASN11)
336 i = i2d_DSAPrivateKey_bio(out, dsakey);
Value stored to 'i' is never read
337 else if (cfg.outformat == FORMAT_PEM3)
338 i = PEM_write_bio_DSAPrivateKey(out, dsakey, NULL((void *)0), NULL((void *)0), 0, NULL((void *)0), NULL((void *)0));
339 else {
340 BIO_printf(bio_err, "bad output format specified for outfile\n");
341 DSA_free(dsakey);
342 goto end;
343 }
344 DSA_free(dsakey);
345 }
346 ret = 0;
347
348 end:
349 BIO_free(in);
350 BIO_free_all(out);
351 BN_GENCB_free(cb);
352 DSA_free(dsa);
353
354 return (ret);
355}
356
357static int
358dsa_cb(int p, int n, BN_GENCB *cb)
359{
360 char c = '*';
361
362 if (p == 0)
363 c = '.';
364 if (p == 1)
365 c = '+';
366 if (p == 2)
367 c = '*';
368 if (p == 3)
369 c = '\n';
370 BIO_write(BN_GENCB_get_arg(cb), &c, 1);
371 (void) BIO_flush(BN_GENCB_get_arg(cb))(int)BIO_ctrl(BN_GENCB_get_arg(cb),11,0,((void *)0));
372#ifdef GENCB_TEST
373 if (stop_keygen_flag)
374 return 0;
375#endif
376 return 1;
377}