/usr/src/sbin/isakmpd/util.c

Bug Summary

File:	src/sbin/isakmpd/util.c
Warning:	line 589, column 3 Potential leak of memory pointed to by 'tmp'

Annotated Source Code

Press '?' to see keyboard shortcuts

Show analyzer invocation

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name util.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/sbin/isakmpd/obj -resource-dir /usr/local/lib/clang/13.0.0 -I /usr/src/sbin/isakmpd -I . -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/sbin/isakmpd/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/sbin/isakmpd/util.c

1/* $OpenBSD: util.c,v 1.72 2019/06/28 13:32:44 deraadt Exp $	 */
2/* $EOM: util.c,v 1.23 2000/11/23 12:22:08 niklas Exp $	 */

4/*
* Copyright (c) 1998, 1999, 2001 Niklas Hallqvist.  All rights reserved.
* Copyright (c) 2000, 2001, 2004 Håkan Olsson.  All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
*    notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
*    notice, this list of conditions and the following disclaimer in the
*    documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

29/*
* This code was written under funding by Ericsson Radio Systems.
*/

33#include <sys/types.h>
34#include <sys/socket.h>
35#include <sys/stat.h>
36#include <netinet/in.h>
37#include <arpa/inet.h>
38#include <limits.h>
39#include <netdb.h>
40#include <stdlib.h>
41#include <string.h>
42#include <unistd.h>
43#include <errno(*__errno()).h>
44#include <ifaddrs.h>
45#include <net/route.h>
46#include <net/if.h>

48#include "log.h"
49#include "message.h"
50#include "monitor.h"
51#include "transport.h"
52#include "util.h"

54/*
* Set if -N is given, allowing name lookups to be done, possibly stalling
* the daemon for quite a while.
*/
58int	allow_name_lookups = 0;

60/*
* XXX These might be turned into inlines or macros, maybe even
* machine-dependent ones, for performance reasons.
*/
64u_int16_t
65decode_16(u_int8_t *cp)
66{
return cp[0] << 8 | cp[1];
68}

70u_int32_t
71decode_32(u_int8_t *cp)
72{
return cp[0] << 24 | cp[1] << 16 | cp[2] << 8 | cp[3];
74}

76void
77encode_16(u_int8_t *cp, u_int16_t x)
78{
*cp++ = x >> 8;
*cp = x & 0xff;
81}

83void
84encode_32(u_int8_t *cp, u_int32_t x)
85{
*cp++ = x >> 24;
*cp++ = (x >> 16) & 0xff;
*cp++ = (x >> 8) & 0xff;
*cp = x & 0xff;
90}

92/* Check a buffer for all zeroes.  */
93int
94zero_test(const u_int8_t *p, size_t sz)
95{
while (sz-- > 0)
if (*p++ != 0)
	return 0;
return 1;
100}

102static __inline int
103hex2nibble(char c)
104{
if (c >= '0' && c <= '9')
return c - '0';
if (c >= 'a' && c <= 'f')
return c - 'a' + 10;
if (c >= 'A' && c <= 'F')
return c - 'A' + 10;
return -1;
112}

114/*
* Convert hexadecimal string in S to raw binary buffer at BUF sized SZ
* bytes.  Return 0 if everything is OK, -1 otherwise.
*/
118int
119hex2raw(char *s, u_int8_t *buf, size_t sz)
120{
u_int8_t *bp;
char	*p;
int	tmp;

if (strlen(s) > sz * 2)
return -1;
for (p = s + strlen(s) - 1, bp = &buf[sz - 1]; bp >= buf; bp--) {
*bp = 0;
if (p >= s) {
	tmp = hex2nibble(*p--);
	if (tmp == -1)
		return -1;
	*bp = tmp;
}
if (p >= s) {
	tmp = hex2nibble(*p--);
	if (tmp == -1)
		return -1;
	*bp |= tmp << 4;
}
}
return 0;
143}

145/*
* Convert raw binary buffer to a newly allocated hexadecimal string.  Returns
* NULL if an error occurred.  It is the caller's responsibility to free the
* returned string.
*/
150char *
151raw2hex(u_int8_t *buf, size_t sz)
152{
char *s;
size_t i;

if ((s = malloc(sz * 2 + 1)) == NULL((void *)0)) {
log_error("raw2hex: malloc (%lu) failed", (unsigned long)sz * 2 + 1);
return NULL((void *)0);
}

for (i = 0; i < sz; i++)
snprintf(s + (2 * i), 2 * (sz - i) + 1, "%02x", buf[i]);

s[sz * 2] = '\0';
return s;
166}

168in_port_t
169text2port(char *port_str)
170{
char           *port_str_end;
long            port_long;
struct servent *service;

port_long = strtol(port_str, &port_str_end, 0);
if (port_str == port_str_end) {
service = getservbyname(port_str, "udp");
if (!service) {
	log_print("text2port: service \"%s\" unknown",
	    port_str);
	return 0;
}
return ntohs(service->s_port)(__uint16_t)(__builtin_constant_p(service->s_port) ? (__uint16_t
)(((__uint16_t)(service->s_port) & 0xffU) << 8 |
 ((__uint16_t)(service->s_port) & 0xff00U) >> 8)
 : __swap16md(service->s_port));
} else if (port_long < 1 || port_long > (long)USHRT_MAX(32767 *2 +1)) {
log_print("text2port: port %ld out of range", port_long);
return 0;
}
return port_long;
189}

191int
192text2sockaddr(char *address, char *port, struct sockaddr **sa, sa_family_t af,
  int netmask)
194{
struct addrinfo *ai, hints;
struct sockaddr_storage tmp_sas;
struct ifaddrs *ifap, *ifa = NULL((void *)0), *llifa = NULL((void *)0);
char *np = address;
char ifname[IFNAMSIZ16];
u_char buf[BUFSIZ1024];
struct rt_msghdr *rtm;
struct sockaddr *sa2;
struct sockaddr_in *sin;
struct sockaddr_in6 *sin6;
int fd = 0, seq, len, b;
pid_t pid;

bzero(&hints, sizeof hints);
if (!allow_name_lookups)
hints.ai_flags = AI_NUMERICHOST4;
hints.ai_family = PF_UNSPEC0;
hints.ai_socktype = SOCK_DGRAM2;
hints.ai_protocol = IPPROTO_UDP17;

if (getaddrinfo(address, port, &hints, &ai)) {
/*
 * If the 'default' keyword is used, do a route lookup for
 * the default route, and use the interface associated with
 * it to select a source address.
 */
if (!strcmp(address, "default")) {
	fd = socket(AF_ROUTE17, SOCK_RAW3, af);

	bzero(buf, sizeof(buf));

	rtm = (struct rt_msghdr *)buf;
	rtm->rtm_version = RTM_VERSION5;
	rtm->rtm_type = RTM_GET0x4;
	rtm->rtm_flags = RTF_UP0x1;
	rtm->rtm_addrs = RTA_DST0x1;
	rtm->rtm_seq = seq = arc4random();

	/* default destination */
	sa2 = (struct sockaddr *)((char *)rtm + rtm->rtm_hdrlen);
	switch (af) {
	case AF_INET2: {
		sin = (struct sockaddr_in *)sa2;
		sin->sin_len = sizeof(*sin);
		sin->sin_family = af;
		break;
	}
	case AF_INET624: {
		sin6 = (struct sockaddr_in6 *)sa2;
		sin6->sin6_len = sizeof(*sin6);
		sin6->sin6_family = af;
		break;
	}
	default:
		close(fd);
		return -1;
	}
	rtm->rtm_addrs |= RTA_NETMASK0x4|RTA_IFP0x10|RTA_IFA0x20;
	rtm->rtm_msglen = sizeof(*rtm) + sizeof(*sa2);

	if ((b = write(fd, buf, rtm->rtm_msglen)) == -1) {
		close(fd);
		return -1;
	}

	pid = getpid();

	while ((len = read(fd, buf, sizeof(buf))) > 0) {
		if (len < sizeof(*rtm)) {
			close(fd);
			return -1;
		}
		if (rtm->rtm_version != RTM_VERSION5)
			continue;

		if (rtm->rtm_type == RTM_GET0x4 &&
		    rtm->rtm_pid == pid &&
		    rtm->rtm_seq == seq) {
			if (rtm->rtm_errno) {
				close(fd);
				return -1;
			}
			break;
		}
	}
	close(fd);

	if ((rtm->rtm_addrs & (RTA_DST0x1|RTA_GATEWAY0x2)) ==
	    (RTA_DST0x1|RTA_GATEWAY0x2)) {
		np = if_indextoname(rtm->rtm_index, ifname);
		if (np == NULL((void *)0))
			return -1;
	}
}

if (getifaddrs(&ifap) != 0)
	return -1;

switch (af) {
default:
case AF_INET2:
	for (ifa = ifap; ifa; ifa = ifa->ifa_next)
		if (!strcmp(ifa->ifa_name, np) &&
		    ifa->ifa_addr != NULL((void *)0) &&
		    ifa->ifa_addr->sa_family == AF_INET2)
			break;
	break;
case AF_INET624:
	for (ifa = ifap; ifa; ifa = ifa->ifa_next) {
		if (!strcmp(ifa->ifa_name, np) &&
		    ifa->ifa_addr != NULL((void *)0) &&
		    ifa->ifa_addr->sa_family == AF_INET624) {
			if (IN6_IS_ADDR_LINKLOCAL((((&((struct sockaddr_in6 *) ifa->ifa_addr)->sin6_addr
)->__u6_addr.__u6_addr8[0] == 0xfe) && (((&((struct
 sockaddr_in6 *) ifa->ifa_addr)->sin6_addr)->__u6_addr
.__u6_addr8[1] & 0xc0) == 0x80))
			    &((struct sockaddr_in6 *)(((&((struct sockaddr_in6 *) ifa->ifa_addr)->sin6_addr
)->__u6_addr.__u6_addr8[0] == 0xfe) && (((&((struct
 sockaddr_in6 *) ifa->ifa_addr)->sin6_addr)->__u6_addr
.__u6_addr8[1] & 0xc0) == 0x80))
			    ifa->ifa_addr)->sin6_addr)(((&((struct sockaddr_in6 *) ifa->ifa_addr)->sin6_addr
)->__u6_addr.__u6_addr8[0] == 0xfe) && (((&((struct
 sockaddr_in6 *) ifa->ifa_addr)->sin6_addr)->__u6_addr
.__u6_addr8[1] & 0xc0) == 0x80)) &&
			    llifa == NULL((void *)0))
				llifa = ifa;
			else
				break;
		}
	}
	if (ifa == NULL((void *)0)) {
		ifa = llifa;
	}
	break;
}

if (ifa) {
	if (netmask)
		memcpy(&tmp_sas, ifa->ifa_netmask,
		    SA_LEN(ifa->ifa_netmask)((ifa->ifa_netmask)->sa_len));
	else
		memcpy(&tmp_sas, ifa->ifa_addr,
		    SA_LEN(ifa->ifa_addr)((ifa->ifa_addr)->sa_len));
	freeifaddrs(ifap);
} else {
	freeifaddrs(ifap);
	return -1;
}
} else {
memcpy(&tmp_sas, ai->ai_addr, SA_LEN(ai->ai_addr)((ai->ai_addr)->sa_len));
freeaddrinfo(ai);
}

*sa = malloc(SA_LEN((struct sockaddr *)&tmp_sas)(((struct sockaddr *)&tmp_sas)->sa_len));
if (!*sa)
return -1;

memcpy(*sa, &tmp_sas, SA_LEN((struct sockaddr *)&tmp_sas)(((struct sockaddr *)&tmp_sas)->sa_len));
return 0;
345}

347/*
* Convert a sockaddr to text. With zflag non-zero fill out with zeroes,
* i.e 10.0.0.10 --> "010.000.000.010"
*/
351int
352sockaddr2text(struct sockaddr *sa, char **address, int zflag)
353{
char	buf[NI_MAXHOST256], *token, *bstart, *ep;
int	addrlen, i, j;
long	val;

if (getnameinfo(sa, SA_LEN(sa)((sa)->sa_len), buf, sizeof buf, 0, 0,
	allow_name_lookups ? 0 : NI_NUMERICHOST1))
return -1;

if (zflag == 0) {
*address = strdup(buf);
if (!*address)
	return -1;
} else
switch (sa->sa_family) {
case AF_INET2:
	addrlen = sizeof "000.000.000.000";
	*address = malloc(addrlen);
	if (!*address)
		return -1;
	buf[addrlen] = '\0';
	bstart = buf;
	**address = '\0';
	while ((token = strsep(&bstart, ".")) != NULL((void *)0)) {
		if (strlen(*address) > 12) {
			free(*address);
			return -1;
		}
		val = strtol(token, &ep, 10);
		if (ep == token || val < (long)0 ||
		    val > (long)UCHAR_MAX(127*2 +1)) {
			free(*address);
			return -1;
		}
		snprintf(*address + strlen(*address),
		    addrlen - strlen(*address), "%03ld", val);
		if (bstart)
			strlcat(*address, ".", addrlen);
	}
	break;

case AF_INET624:
	/*
	 * XXX In the algorithm below there are some magic
	 * numbers we probably could give explaining names.
	 */
	addrlen =
	    sizeof "0000:0000:0000:0000:0000:0000:0000:0000";
	*address = malloc(addrlen);
	if (!*address)
		return -1;

	for (i = 0, j = 0; i < 8; i++) {
		snprintf((*address) + j, addrlen - j,
		    "%02x%02x",
		    ((struct sockaddr_in6 *)sa)->sin6_addr.s6_addr__u6_addr.__u6_addr8[2*i],
		    ((struct sockaddr_in6 *)sa)->sin6_addr.s6_addr__u6_addr.__u6_addr8[2*i + 1]);
		j += 4;
		(*address)[j] =
		    (j < (addrlen - 1)) ? ':' : '\0';
		j++;
	}
	break;

default:
	*address = strdup("<error>");
	if (!*address)
		return -1;
}

return 0;
424}

426/*
* sockaddr_addrlen and sockaddr_addrdata return the relevant sockaddr info
* depending on address family.  Useful to keep other code shorter(/clearer?).
*/
430int
431sockaddr_addrlen(struct sockaddr *sa)
432{
switch (sa->sa_family) {
case AF_INET624:
return sizeof((struct sockaddr_in6 *)sa)->sin6_addr.s6_addr__u6_addr.__u6_addr8;
case AF_INET2:
return sizeof((struct sockaddr_in *)sa)->sin_addr.s_addr;
default:
log_print("sockaddr_addrlen: unsupported protocol family %d",
    sa->sa_family);
return 0;
}
443}

445u_int8_t *
446sockaddr_addrdata(struct sockaddr *sa)
447{
switch (sa->sa_family) {
case AF_INET624:
return (u_int8_t *)&((struct sockaddr_in6 *)sa)->sin6_addr.s6_addr__u6_addr.__u6_addr8;
case AF_INET2:
return (u_int8_t *)&((struct sockaddr_in *)sa)->sin_addr.s_addr;
default:
log_print("sockaddr_addrdata: unsupported protocol family %d",
    sa->sa_family);
return 0;
}
458}

460in_port_t
461sockaddr_port(struct sockaddr *sa)
462{
switch (sa->sa_family) {
case AF_INET624:
return ((struct sockaddr_in6 *)sa)->sin6_port;
case AF_INET2:
return ((struct sockaddr_in *)sa)->sin_port;
default:
log_print("sockaddr_port: unsupported protocol family %d",
    sa->sa_family);
return 0;
}
473}

475/* Utility function used to set the port of a sockaddr.  */
476void
477sockaddr_set_port(struct sockaddr *sa, in_port_t port)
478{
switch (sa->sa_family) {
case AF_INET2:
((struct sockaddr_in *)sa)->sin_port = htons (port)(__uint16_t)(__builtin_constant_p(port) ? (__uint16_t)(((__uint16_t
)(port) & 0xffU) << 8 | ((__uint16_t)(port) & 0xff00U
) >> 8) : __swap16md(port));
break;

case AF_INET624:
((struct sockaddr_in6 *)sa)->sin6_port = htons (port)(__uint16_t)(__builtin_constant_p(port) ? (__uint16_t)(((__uint16_t
)(port) & 0xffU) << 8 | ((__uint16_t)(port) & 0xff00U
) >> 8) : __swap16md(port));
break;
}
488}

490/*
* Convert network address to text. The network address does not need
* to be properly aligned.
*/
494void
495util_ntoa(char **buf, int af, u_int8_t *addr)
496{
struct sockaddr_storage from;
struct sockaddr *sfrom = (struct sockaddr *) & from;
socklen_t	fromlen = sizeof from;

bzero(&from, fromlen);
sfrom->sa_family = af;

switch (af) {
case AF_INET2:
sfrom->sa_len = sizeof(struct sockaddr_in);
break;
case AF_INET624:
sfrom->sa_len = sizeof(struct sockaddr_in6);
break;
}

memcpy(sockaddr_addrdata(sfrom), addr, sockaddr_addrlen(sfrom));

if (sockaddr2text(sfrom, buf, 0)) {
log_print("util_ntoa: could not make printable address out "
    "of sockaddr %p", sfrom);
*buf = 0;
}
520}

522/*
* Perform sanity check on files containing secret information.
* Returns -1 on failure, 0 otherwise.
* Also, if FILE_SIZE is a not a null pointer, store file size here.
*/

528int
529check_file_secrecy_fd(int fd, char *name, size_t *file_size)
530{
struct stat st;

if (fstat(fd, &st) == -1) {
log_error("check_file_secrecy: stat (\"%s\") failed", name);
return -1;
}
if (st.st_uid != 0 && st.st_uid != getuid()) {
log_print("check_file_secrecy_fd: "
    "not loading %s - file owner is not process user", name);
errno(*__errno()) = EPERM1;
return -1;
}
if ((st.st_mode & (S_IRWXG0000070 | S_IRWXO0000007)) != 0) {
log_print("check_file_secrecy_fd: not loading %s - too open "
    "permissions", name);
errno(*__errno()) = EPERM1;
return -1;
}
if (file_size)
*file_size = (size_t)st.st_size;

return 0;
553}

555/* Calculate timeout.  Returns -1 on error. */
556long
557get_timeout(struct timespec *timeout)
558{
struct timespec	now, result;

if (clock_gettime(CLOCK_MONOTONIC3, &now) == -1)
return -1;
timespecsub(timeout, &now, &result)do { (&result)->tv_sec = (timeout)->tv_sec - (&
now)->tv_sec; (&result)->tv_nsec = (timeout)->tv_nsec
 - (&now)->tv_nsec; if ((&result)->tv_nsec <
 0) { (&result)->tv_sec--; (&result)->tv_nsec +=
 1000000000L; } } while (0);
return result.tv_sec;
565}

567int
568expand_string(char *label, size_t len, const char *srch, const char *repl)
569{
char *tmp;
char *p, *q;

if ((tmp = calloc(1, len)) == NULL((void *)0)) {
1
Memory is allocated→
2
←
Assuming the condition is false→
3
←
Taking false branch→
log_error("expand_string: calloc");
return (-1);
}
p = q = label;
while ((q = strstr(p, srch)) != NULL((void *)0)) {
4
←
Assuming the condition is false→
5
←
Loop condition is false. Execution continues on line 588→
*q = '\0';
if ((strlcat(tmp, p, len) >= len) ||
    (strlcat(tmp, repl, len) >= len)) {
	log_print("expand_string: string too long");
	return (-1);
}
q += strlen(srch);
p = q;
}
if (strlcat(tmp, p, len) >= len) {
6
←
Assuming the condition is true→
7
←
Taking true branch→
log_print("expand_string: string too long");
8
←
Potential leak of memory pointed to by 'tmp'
return (-1);
}
strlcpy(label, tmp, len);	/* always fits */
free(tmp);

return (0);
596}