Bug Summary

File:src/bin/ls/ls.c
Warning:line 448, column 2
Value stored to 'flen' is never read

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name ls.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/bin/ls/obj -resource-dir /usr/local/lib/clang/13.0.0 -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/bin/ls/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/bin/ls/ls.c
1/* $OpenBSD: ls.c,v 1.54 2020/10/07 21:03:09 millert Exp $ */
2/* $NetBSD: ls.c,v 1.18 1996/07/09 09:16:29 mycroft Exp $ */
3
4/*
5 * Copyright (c) 1989, 1993, 1994
6 * The Regents of the University of California. All rights reserved.
7 *
8 * This code is derived from software contributed to Berkeley by
9 * Michael Fischbein.
10 *
11 * Redistribution and use in source and binary forms, with or without
12 * modification, are permitted provided that the following conditions
13 * are met:
14 * 1. Redistributions of source code must retain the above copyright
15 * notice, this list of conditions and the following disclaimer.
16 * 2. Redistributions in binary form must reproduce the above copyright
17 * notice, this list of conditions and the following disclaimer in the
18 * documentation and/or other materials provided with the distribution.
19 * 3. Neither the name of the University nor the names of its contributors
20 * may be used to endorse or promote products derived from this software
21 * without specific prior written permission.
22 *
23 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
24 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
25 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
26 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
27 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
28 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
29 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
30 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
31 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
32 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
33 * SUCH DAMAGE.
34 */
35
36#include <sys/types.h>
37#include <sys/stat.h>
38#include <sys/ioctl.h>
39
40#include <dirent.h>
41#include <err.h>
42#include <errno(*__errno()).h>
43#include <fts.h>
44#include <grp.h>
45#include <pwd.h>
46#include <stdio.h>
47#include <stdlib.h>
48#include <string.h>
49#include <unistd.h>
50#include <limits.h>
51#include <locale.h>
52#include <util.h>
53
54#include "ls.h"
55#include "extern.h"
56
57static void display(FTSENT *, FTSENT *);
58static int mastercmp(const FTSENT **, const FTSENT **);
59static void traverse(int, char **, int);
60
61static void (*printfcn)(DISPLAY *);
62static int (*sortfcn)(const FTSENT *, const FTSENT *);
63
64#define BY_NAME0 0
65#define BY_SIZE1 1
66#define BY_TIME2 2
67
68long blocksize; /* block size units */
69int termwidth; /* default terminal width */
70int sortkey = BY_NAME0;
71
72/* flags */
73int f_accesstime; /* use time of last access */
74int f_column; /* columnated format */
75int f_columnacross; /* columnated format, sorted across */
76int f_flags; /* show flags associated with a file */
77int f_grouponly; /* long listing format without owner */
78int f_humanval; /* show human-readable file sizes */
79int f_inode; /* print inode */
80int f_listdir; /* list actual directory, not contents */
81int f_listdot; /* list files beginning with . */
82int f_longform; /* long listing format */
83int f_nonprint; /* show unprintables as ? */
84int f_nosort; /* don't sort output */
85int f_numericonly; /* don't expand uid to symbolic name */
86int f_recursive; /* ls subdirectories also */
87int f_reversesort; /* reverse whatever sort is used */
88int f_sectime; /* print the real time for all files */
89int f_singlecol; /* use single column output */
90int f_size; /* list size in short listing */
91int f_statustime; /* use time of last mode change */
92int f_stream; /* stream format */
93int f_type; /* add type character for non-regular files */
94int f_typedir; /* add type character for directories */
95
96int rval;
97
98int
99ls_main(int argc, char *argv[])
100{
101 static char dot[] = ".", *dotav[] = { dot, NULL((void *)0) };
102 struct winsize win;
103 int ch, fts_options, notused;
104 int kflag = 0;
105 char *p;
106
107#ifndef SMALL
108 setlocale(LC_CTYPE2, "");
109#endif
110
111 /* Terminal defaults to -Cq, non-terminal defaults to -1. */
112 if (isatty(STDOUT_FILENO1)) {
113 f_column = f_nonprint = 1;
114 } else {
115 f_singlecol = 1;
116 }
117
118 termwidth = 0;
119 if ((p = getenv("COLUMNS")) != NULL((void *)0))
120 termwidth = strtonum(p, 1, INT_MAX2147483647, NULL((void *)0));
121 if (termwidth == 0 && ioctl(STDOUT_FILENO1, TIOCGWINSZ((unsigned long)0x40000000 | ((sizeof(struct winsize) & 0x1fff
) << 16) | ((('t')) << 8) | ((104)))
, &win) == 0 &&
122 win.ws_col > 0)
123 termwidth = win.ws_col;
124 if (termwidth == 0)
125 termwidth = 80;
126
127 if (pledge("stdio rpath getpw", NULL((void *)0)) == -1)
128 err(1, "pledge");
129
130 /* Root is -A automatically. */
131 if (!getuid())
132 f_listdot = 1;
133
134 fts_options = FTS_PHYSICAL0x0010;
135 while ((ch = getopt(argc, argv, "1ACFHLRSTacdfghiklmnopqrstux")) != -1) {
136 switch (ch) {
137 /*
138 * The -1, -C and -l, -m, -n and -x options all override each
139 * other so shell aliasing works right.
140 */
141 case '1':
142 f_singlecol = 1;
143 f_column = f_columnacross = f_longform = 0;
144 f_numericonly = f_stream = 0;
145 break;
146 case 'C':
147 f_column = 1;
148 f_columnacross = f_longform = f_numericonly = 0;
149 f_singlecol = f_stream = 0;
150 break;
151 case 'g':
152 f_longform = 1;
153 if (f_grouponly != -1)
154 f_grouponly = 1;
155 f_column = f_columnacross = f_singlecol = f_stream = 0;
156 break;
157 case 'l':
158 f_longform = 1;
159 f_grouponly = -1; /* -l always overrides -g */
160 f_column = f_columnacross = f_singlecol = f_stream = 0;
161 break;
162 case 'm':
163 f_stream = 1;
164 f_column = f_columnacross = f_longform = 0;
165 f_numericonly = f_singlecol = 0;
166 break;
167 case 'x':
168 f_columnacross = 1;
169 f_column = f_longform = f_numericonly = 0;
170 f_singlecol = f_stream = 0;
171 break;
172 case 'n':
173 f_longform = 1;
174 f_numericonly = 1;
175 f_column = f_columnacross = f_singlecol = f_stream = 0;
176 break;
177 /* The -c and -u options override each other. */
178 case 'c':
179 f_statustime = 1;
180 f_accesstime = 0;
181 break;
182 case 'u':
183 f_accesstime = 1;
184 f_statustime = 0;
185 break;
186 case 'F':
187 f_type = 1;
188 break;
189 case 'H':
190 fts_options |= FTS_COMFOLLOW0x0001;
191 break;
192 case 'L':
193 fts_options &= ~FTS_PHYSICAL0x0010;
194 fts_options |= FTS_LOGICAL0x0002;
195 break;
196 case 'R':
197 f_recursive = 1;
198 break;
199 case 'f':
200 f_nosort = 1;
201 /* FALLTHROUGH */
202 case 'a':
203 fts_options |= FTS_SEEDOT0x0020;
204 /* FALLTHROUGH */
205 case 'A':
206 f_listdot = 1;
207 break;
208 /* The -d option turns off the -R option. */
209 case 'd':
210 f_listdir = 1;
211 f_recursive = 0;
212 break;
213 case 'h':
214 f_humanval = 1;
215 break;
216 case 'i':
217 f_inode = 1;
218 break;
219 case 'k':
220 blocksize = 1024;
221 kflag = 1;
222 break;
223 case 'o':
224 f_flags = 1;
225 break;
226 case 'p':
227 f_typedir = 1;
228 break;
229 case 'q':
230 f_nonprint = 1;
231 break;
232 case 'r':
233 f_reversesort = 1;
234 break;
235 case 'S':
236 sortkey = BY_SIZE1;
237 break;
238 case 's':
239 f_size = 1;
240 break;
241 case 'T':
242 f_sectime = 1;
243 break;
244 case 't':
245 sortkey = BY_TIME2;
246 break;
247 default:
248 usage();
249 }
250 }
251 argc -= optind;
252 argv += optind;
253
254 /*
255 * If both -g and -l options, let -l take precedence.
256 * This preserves compatibility with the historic BSD ls -lg.
257 */
258 if (f_grouponly == -1)
259 f_grouponly = 0;
260
261 /*
262 * If not -F, -i, -l, -p, -S, -s or -t options, don't require stat
263 * information.
264 */
265 if (!f_longform && !f_inode && !f_size && !f_type && !f_typedir &&
266 sortkey == BY_NAME0)
267 fts_options |= FTS_NOSTAT0x0008;
268
269 /*
270 * If not -F, -d or -l options, follow any symbolic links listed on
271 * the command line.
272 */
273 if (!f_longform && !f_listdir && !f_type)
274 fts_options |= FTS_COMFOLLOW0x0001;
275
276 /* If -l or -s, figure out block size. */
277 if (f_longform || f_size) {
278 if (!kflag)
279 (void)getbsize(&notused, &blocksize);
280 blocksize /= 512;
281 }
282
283 /* Select a sort function. */
284 if (f_reversesort) {
285 switch (sortkey) {
286 case BY_NAME0:
287 sortfcn = revnamecmp;
288 break;
289 case BY_SIZE1:
290 sortfcn = revsizecmp;
291 break;
292 case BY_TIME2:
293 if (f_accesstime)
294 sortfcn = revacccmp;
295 else if (f_statustime)
296 sortfcn = revstatcmp;
297 else /* Use modification time. */
298 sortfcn = revmodcmp;
299 break;
300 }
301 } else {
302 switch (sortkey) {
303 case BY_NAME0:
304 sortfcn = namecmp;
305 break;
306 case BY_SIZE1:
307 sortfcn = sizecmp;
308 break;
309 case BY_TIME2:
310 if (f_accesstime)
311 sortfcn = acccmp;
312 else if (f_statustime)
313 sortfcn = statcmp;
314 else /* Use modification time. */
315 sortfcn = modcmp;
316 break;
317 }
318 }
319
320 /* Select a print function. */
321 if (f_singlecol)
322 printfcn = printscol;
323 else if (f_columnacross)
324 printfcn = printacol;
325 else if (f_longform)
326 printfcn = printlong;
327 else if (f_stream)
328 printfcn = printstream;
329 else
330 printfcn = printcol;
331
332 if (argc)
333 traverse(argc, argv, fts_options);
334 else
335 traverse(1, dotav, fts_options);
336 return (rval);
337}
338
339static int output; /* If anything output. */
340
341/*
342 * Traverse() walks the logical directory structure specified by the argv list
343 * in the order specified by the mastercmp() comparison function. During the
344 * traversal it passes linked lists of structures to display() which represent
345 * a superset (may be exact set) of the files to be displayed.
346 */
347static void
348traverse(int argc, char *argv[], int options)
349{
350 FTS *ftsp;
351 FTSENT *p, *chp;
352 int ch_options, saved_errno;
353
354 if ((ftsp =
355 fts_open(argv, options, f_nosort ? NULL((void *)0) : mastercmp)) == NULL((void *)0))
356 err(1, NULL((void *)0));
357
358 /*
359 * We ignore errors from fts_children here since they will be
360 * replicated and signalled on the next call to fts_read() below.
361 */
362 chp = fts_children(ftsp, 0);
363 if (chp != NULL((void *)0))
364 display(NULL((void *)0), chp);
365 if (f_listdir)
366 return;
367
368 /*
369 * If not recursing down this tree and don't need stat info, just get
370 * the names.
371 */
372 ch_options = !f_recursive && options & FTS_NOSTAT0x0008 ? FTS_NAMEONLY0x1000 : 0;
373
374 while ((p = fts_read(ftsp)) != NULL((void *)0))
375 switch (p->fts_info) {
376 case FTS_D1:
377 if (p->fts_name[0] == '.' &&
378 p->fts_level != FTS_ROOTLEVEL0 && !f_listdot) {
379 (void)fts_set(ftsp, p, FTS_SKIP4);
380 break;
381 }
382
383 /*
384 * If already output something, put out a newline as
385 * a separator. If multiple arguments, precede each
386 * directory with its name.
387 */
388 if (output)
389 (void)printf("\n%s:\n", p->fts_path);
390 else if (f_recursive || argc > 1) {
391 (void)printf("%s:\n", p->fts_path);
392 output = 1;
393 }
394
395 chp = fts_children(ftsp, ch_options);
396 saved_errno = errno(*__errno());
397 display(p, chp);
398
399 /*
400 * On fts_children() returning error do recurse to see
401 * the error.
402 */
403 if (!f_recursive && !(chp == NULL((void *)0) && saved_errno != 0))
404 (void)fts_set(ftsp, p, FTS_SKIP4);
405 break;
406 case FTS_DC2:
407 warnx("%s: directory causes a cycle", p->fts_name);
408 break;
409 case FTS_DNR4:
410 case FTS_ERR7:
411 warnx("%s: %s", p->fts_name[0] == '\0' ? p->fts_path :
412 p->fts_name, strerror(p->fts_errno));
413 rval = 1;
414 break;
415 }
416 if (errno(*__errno()))
417 err(1, "fts_read");
418
419 fts_close(ftsp);
420}
421
422/*
423 * Display() takes a linked list of FTSENT structures and passes the list
424 * along with any other necessary information to the print function. P
425 * points to the parent directory of the display list.
426 */
427static void
428display(FTSENT *p, FTSENT *list)
429{
430 struct stat *sp;
431 DISPLAY d;
432 FTSENT *cur;
433 NAMES *np;
434 off_t maxsize;
435 nlink_t maxnlink;
436 unsigned long long btotal;
437 blkcnt_t maxblock;
438 ino_t maxinode;
439 int bcfile, flen, glen, ulen, maxflags, maxgroup, maxuser, maxlen;
440 int entries, needstats;
441 int width;
442 const char *user, *group;
443 char nuser[12], ngroup[12];
444 char buf[21]; /* 64 bits == 20 digits */
445 char *flags = NULL((void *)0);
446
447 needstats = f_inode || f_longform || f_size;
448 flen = 0;
Value stored to 'flen' is never read
449 btotal = maxblock = maxinode = maxlen = maxnlink = 0;
450 bcfile = 0;
451 maxuser = maxgroup = maxflags = 0;
452 maxsize = 0;
453 for (cur = list, entries = 0; cur != NULL((void *)0); cur = cur->fts_link) {
454 if (cur->fts_info == FTS_ERR7 || cur->fts_info == FTS_NS10) {
455 warnx("%s: %s",
456 cur->fts_name, strerror(cur->fts_errno));
457 cur->fts_number = NO_PRINT1;
458 rval = 1;
459 continue;
460 }
461
462 /*
463 * P is NULL if list is the argv list, to which different rules
464 * apply.
465 */
466 if (p == NULL((void *)0)) {
467 /* Directories will be displayed later. */
468 if (cur->fts_info == FTS_D1 && !f_listdir) {
469 cur->fts_number = NO_PRINT1;
470 continue;
471 }
472 } else {
473 /* Only display dot file if -a/-A set. */
474 if (cur->fts_name[0] == '.' && !f_listdot) {
475 cur->fts_number = NO_PRINT1;
476 continue;
477 }
478 }
479 if ((width = mbsprint(cur->fts_name, 0)) > maxlen)
480 maxlen = width;
481 if (needstats) {
482 sp = cur->fts_statp;
483 if (sp->st_blocks > maxblock)
484 maxblock = sp->st_blocks;
485 if (sp->st_ino > maxinode)
486 maxinode = sp->st_ino;
487 if (sp->st_nlink > maxnlink)
488 maxnlink = sp->st_nlink;
489 if (sp->st_size > maxsize)
490 maxsize = sp->st_size;
491
492 btotal += sp->st_blocks;
493 if (f_longform) {
494 if (f_numericonly) {
495 snprintf(nuser, sizeof nuser, "%u", sp->st_uid);
496 snprintf(ngroup, sizeof nuser, "%u", sp->st_gid);
497 user = nuser;
498 group = ngroup;
499 } else {
500 user = user_from_uid(sp->st_uid, 0);
501 group = group_from_gid(sp->st_gid, 0);
502 }
503 if ((ulen = strlen(user)) > maxuser)
504 maxuser = ulen;
505 if ((glen = strlen(group)) > maxgroup)
506 maxgroup = glen;
507 if (f_flags) {
508 flags = fflagstostr(sp->st_flags);
509 if (*flags == '\0')
510 flags = "-";
511 if ((flen = strlen(flags)) > maxflags)
512 maxflags = flen;
513 } else
514 flen = 0;
515
516 if ((np = malloc(sizeof(NAMES) +
517 ulen + 1 + glen + 1 + flen + 1)) == NULL((void *)0))
518 err(1, NULL((void *)0));
519
520 np->user = &np->data[0];
521 (void)strlcpy(np->user, user, ulen + 1);
522 np->group = &np->data[ulen + 1];
523 (void)strlcpy(np->group, group, glen + 1);
524
525 if (S_ISCHR(sp->st_mode)((sp->st_mode & 0170000) == 0020000) ||
526 S_ISBLK(sp->st_mode)((sp->st_mode & 0170000) == 0060000))
527 bcfile = 1;
528
529 if (f_flags) {
530 np->flags = &np->data[ulen + 1 + glen + 1];
531 (void)strlcpy(np->flags, flags, flen + 1);
532 if (*flags != '-')
533 free(flags);
534 }
535 cur->fts_pointer = np;
536 }
537 }
538 ++entries;
539 }
540
541 /*
542 * If there are no entries to display, we normally stop right
543 * here. However, we must continue if we have to display the
544 * total block count. In this case, we display the total only
545 * on the second (p != NULL) pass.
546 */
547 if (!entries && (!(f_longform || f_size) || p == NULL((void *)0)))
548 return;
549
550 d.list = list;
551 d.entries = entries;
552 d.maxlen = maxlen;
553 if (needstats) {
554 d.bcfile = bcfile;
555 d.btotal = btotal;
556 (void)snprintf(buf, sizeof(buf), "%llu",
557 (unsigned long long)maxblock);
558 d.s_block = strlen(buf);
559 d.s_flags = maxflags;
560 d.s_group = maxgroup;
561 (void)snprintf(buf, sizeof(buf), "%llu",
562 (unsigned long long)maxinode);
563 d.s_inode = strlen(buf);
564 (void)snprintf(buf, sizeof(buf), "%lu",
565 (unsigned long)maxnlink);
566 d.s_nlink = strlen(buf);
567 if (!f_humanval) {
568 (void)snprintf(buf, sizeof(buf), "%lld",
569 (long long)maxsize);
570 d.s_size = strlen(buf);
571 } else
572 d.s_size = FMT_SCALED_STRSIZE7-2; /* no - or '\0' */
573 d.s_user = maxuser;
574 }
575
576 printfcn(&d);
577 output = 1;
578
579 if (f_longform)
580 for (cur = list; cur != NULL((void *)0); cur = cur->fts_link)
581 free(cur->fts_pointer);
582}
583
584/*
585 * Ordering for mastercmp:
586 * If ordering the argv (fts_level = FTS_ROOTLEVEL) return non-directories
587 * as larger than directories. Within either group, use the sort function.
588 * All other levels use the sort function. Error entries remain unsorted.
589 */
590static int
591mastercmp(const FTSENT **a, const FTSENT **b)
592{
593 int a_info, b_info;
594
595 a_info = (*a)->fts_info;
596 if (a_info == FTS_ERR7)
597 return (0);
598 b_info = (*b)->fts_info;
599 if (b_info == FTS_ERR7)
600 return (0);
601
602 if (a_info == FTS_NS10 || b_info == FTS_NS10) {
603 if (b_info != FTS_NS10)
604 return (1);
605 else if (a_info != FTS_NS10)
606 return (-1);
607 else
608 return (namecmp(*a, *b));
609 }
610
611 if (a_info != b_info &&
612 (*a)->fts_level == FTS_ROOTLEVEL0 && !f_listdir) {
613 if (a_info == FTS_D1)
614 return (1);
615 if (b_info == FTS_D1)
616 return (-1);
617 }
618 return (sortfcn(*a, *b));
619}