Bug Summary

File:src/lib/libcrypto/ocsp/ocsp_prn.c
Warning:line 227, column 2
Value stored to 'i' is never read

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name ocsp_prn.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -fhalf-no-semantic-interposition -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/lib/libcrypto/obj -resource-dir /usr/local/lib/clang/13.0.0 -D LIBRESSL_INTERNAL -D LIBRESSL_CRYPTO_INTERNAL -D DSO_DLFCN -D HAVE_DLFCN_H -D HAVE_FUNOPEN -D OPENSSL_NO_HW_PADLOCK -I /usr/src/lib/libcrypto -I /usr/src/lib/libcrypto/asn1 -I /usr/src/lib/libcrypto/bio -I /usr/src/lib/libcrypto/bn -I /usr/src/lib/libcrypto/bytestring -I /usr/src/lib/libcrypto/dh -I /usr/src/lib/libcrypto/dsa -I /usr/src/lib/libcrypto/ec -I /usr/src/lib/libcrypto/ecdh -I /usr/src/lib/libcrypto/ecdsa -I /usr/src/lib/libcrypto/evp -I /usr/src/lib/libcrypto/hmac -I /usr/src/lib/libcrypto/modes -I /usr/src/lib/libcrypto/ocsp -I /usr/src/lib/libcrypto/rsa -I /usr/src/lib/libcrypto/x509 -I /usr/src/lib/libcrypto/obj -D AES_ASM -D BSAES_ASM -D VPAES_ASM -D OPENSSL_IA32_SSE2 -D RSA_ASM -D OPENSSL_BN_ASM_MONT -D OPENSSL_BN_ASM_MONT5 -D OPENSSL_BN_ASM_GF2m -D MD5_ASM -D GHASH_ASM -D RC4_MD5_ASM -D SHA1_ASM -D SHA256_ASM -D SHA512_ASM -D WHIRLPOOL_ASM -D OPENSSL_CPUID_OBJ -D PIC -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/lib/libcrypto/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/lib/libcrypto/ocsp/ocsp_prn.c
1/* $OpenBSD: ocsp_prn.c,v 1.9 2022/01/07 09:45:52 tb Exp $ */
2/* Written by Tom Titchener <Tom_Titchener@groove.net> for the OpenSSL
3 * project. */
4
5/* History:
6 This file was originally part of ocsp.c and was transfered to Richard
7 Levitte from CertCo by Kathy Weinhold in mid-spring 2000 to be included
8 in OpenSSL or released as a patch kit. */
9
10/* ====================================================================
11 * Copyright (c) 1998-2000 The OpenSSL Project. All rights reserved.
12 *
13 * Redistribution and use in source and binary forms, with or without
14 * modification, are permitted provided that the following conditions
15 * are met:
16 *
17 * 1. Redistributions of source code must retain the above copyright
18 * notice, this list of conditions and the following disclaimer.
19 *
20 * 2. Redistributions in binary form must reproduce the above copyright
21 * notice, this list of conditions and the following disclaimer in
22 * the documentation and/or other materials provided with the
23 * distribution.
24 *
25 * 3. All advertising materials mentioning features or use of this
26 * software must display the following acknowledgment:
27 * "This product includes software developed by the OpenSSL Project
28 * for use in the OpenSSL Toolkit. (http://www.openssl.org/)"
29 *
30 * 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to
31 * endorse or promote products derived from this software without
32 * prior written permission. For written permission, please contact
33 * openssl-core@openssl.org.
34 *
35 * 5. Products derived from this software may not be called "OpenSSL"
36 * nor may "OpenSSL" appear in their names without prior written
37 * permission of the OpenSSL Project.
38 *
39 * 6. Redistributions of any form whatsoever must retain the following
40 * acknowledgment:
41 * "This product includes software developed by the OpenSSL Project
42 * for use in the OpenSSL Toolkit (http://www.openssl.org/)"
43 *
44 * THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY
45 * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
46 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
47 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE OpenSSL PROJECT OR
48 * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
49 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
50 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
51 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
52 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
53 * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
54 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
55 * OF THE POSSIBILITY OF SUCH DAMAGE.
56 * ====================================================================
57 *
58 * This product includes cryptographic software written by Eric Young
59 * (eay@cryptsoft.com). This product includes software written by Tim
60 * Hudson (tjh@cryptsoft.com).
61 *
62 */
63
64#include <openssl/bio.h>
65#include <openssl/err.h>
66#include <openssl/ocsp.h>
67#include <openssl/pem.h>
68
69#include "ocsp_local.h"
70
71static int
72ocsp_certid_print(BIO *bp, OCSP_CERTID* a, int indent)
73{
74 BIO_printf(bp, "%*sCertificate ID:\n", indent, "");
75 indent += 2;
76 BIO_printf(bp, "%*sHash Algorithm: ", indent, "");
77 i2a_ASN1_OBJECT(bp, a->hashAlgorithm->algorithm);
78 BIO_printf(bp, "\n%*sIssuer Name Hash: ", indent, "");
79 i2a_ASN1_STRING(bp, a->issuerNameHash, V_ASN1_OCTET_STRING4);
80 BIO_printf(bp, "\n%*sIssuer Key Hash: ", indent, "");
81 i2a_ASN1_STRING(bp, a->issuerKeyHash, V_ASN1_OCTET_STRING4);
82 BIO_printf(bp, "\n%*sSerial Number: ", indent, "");
83 i2a_ASN1_INTEGER(bp, a->serialNumber);
84 BIO_printf(bp, "\n");
85 return 1;
86}
87
88typedef struct {
89 long t;
90 const char *m;
91} OCSP_TBLSTR;
92
93static const char *
94table2string(long s, const OCSP_TBLSTR *ts, int len)
95{
96 const OCSP_TBLSTR *p;
97
98 for (p = ts; p < ts + len; p++)
99 if (p->t == s)
100 return p->m;
101 return "(UNKNOWN)";
102}
103
104const char *
105OCSP_response_status_str(long s)
106{
107 static const OCSP_TBLSTR rstat_tbl[] = {
108 { OCSP_RESPONSE_STATUS_SUCCESSFUL0, "successful" },
109 { OCSP_RESPONSE_STATUS_MALFORMEDREQUEST1, "malformedrequest" },
110 { OCSP_RESPONSE_STATUS_INTERNALERROR2, "internalerror" },
111 { OCSP_RESPONSE_STATUS_TRYLATER3, "trylater" },
112 { OCSP_RESPONSE_STATUS_SIGREQUIRED5, "sigrequired" },
113 { OCSP_RESPONSE_STATUS_UNAUTHORIZED6, "unauthorized" }
114 };
115 return table2string(s, rstat_tbl, 6);
116}
117
118const char *
119OCSP_cert_status_str(long s)
120{
121 static const OCSP_TBLSTR cstat_tbl[] = {
122 { V_OCSP_CERTSTATUS_GOOD0, "good" },
123 { V_OCSP_CERTSTATUS_REVOKED1, "revoked" },
124 { V_OCSP_CERTSTATUS_UNKNOWN2, "unknown" }
125 };
126 return table2string(s, cstat_tbl, 3);
127}
128
129const char *
130OCSP_crl_reason_str(long s)
131{
132 static const OCSP_TBLSTR reason_tbl[] = {
133 { OCSP_REVOKED_STATUS_UNSPECIFIED0, "unspecified" },
134 { OCSP_REVOKED_STATUS_KEYCOMPROMISE1, "keyCompromise" },
135 { OCSP_REVOKED_STATUS_CACOMPROMISE2, "cACompromise" },
136 { OCSP_REVOKED_STATUS_AFFILIATIONCHANGED3, "affiliationChanged" },
137 { OCSP_REVOKED_STATUS_SUPERSEDED4, "superseded" },
138 { OCSP_REVOKED_STATUS_CESSATIONOFOPERATION5, "cessationOfOperation" },
139 { OCSP_REVOKED_STATUS_CERTIFICATEHOLD6, "certificateHold" },
140 { OCSP_REVOKED_STATUS_REMOVEFROMCRL8, "removeFromCRL" }
141 };
142 return table2string(s, reason_tbl, 8);
143}
144
145int
146OCSP_REQUEST_print(BIO *bp, OCSP_REQUEST* o, unsigned long flags)
147{
148 int i;
149 long l;
150 OCSP_CERTID* cid = NULL((void*)0);
151 OCSP_ONEREQ *one = NULL((void*)0);
152 OCSP_REQINFO *inf = o->tbsRequest;
153 OCSP_SIGNATURE *sig = o->optionalSignature;
154
155 if (BIO_write(bp, "OCSP Request Data:\n", 19) <= 0)
156 goto err;
157 l = ASN1_INTEGER_get(inf->version);
158 if (BIO_printf(bp, " Version: %lu (0x%lx)", l+1, l) <= 0)
159 goto err;
160 if (inf->requestorName != NULL((void*)0)) {
161 if (BIO_write(bp, "\n Requestor Name: ", 21) <= 0)
162 goto err;
163 GENERAL_NAME_print(bp, inf->requestorName);
164 }
165 if (BIO_write(bp, "\n Requestor List:\n", 21) <= 0)
166 goto err;
167 for (i = 0; i < sk_OCSP_ONEREQ_num(inf->requestList)sk_num(((_STACK*) (1 ? (inf->requestList) : (struct stack_st_OCSP_ONEREQ
*)0)))
; i++) {
168 one = sk_OCSP_ONEREQ_value(inf->requestList, i)((OCSP_ONEREQ *)sk_value(((_STACK*) (1 ? (inf->requestList
) : (struct stack_st_OCSP_ONEREQ*)0)), (i)))
;
169 cid = one->reqCert;
170 ocsp_certid_print(bp, cid, 8);
171 if (!X509V3_extensions_print(bp, "Request Single Extensions",
172 one->singleRequestExtensions, flags, 8))
173 goto err;
174 }
175 if (!X509V3_extensions_print(bp, "Request Extensions",
176 inf->requestExtensions, flags, 4))
177 goto err;
178 if (sig) {
179 if (X509_signature_print(bp, sig->signatureAlgorithm,
180 sig->signature) == 0)
181 goto err;
182 for (i = 0; i < sk_X509_num(sig->certs)sk_num(((_STACK*) (1 ? (sig->certs) : (struct stack_st_X509
*)0)))
; i++) {
183 if (X509_print(bp, sk_X509_value(sig->certs, i)((X509 *)sk_value(((_STACK*) (1 ? (sig->certs) : (struct stack_st_X509
*)0)), (i)))
) == 0)
184 goto err;
185 if (PEM_write_bio_X509(bp,
186 sk_X509_value(sig->certs, i)((X509 *)sk_value(((_STACK*) (1 ? (sig->certs) : (struct stack_st_X509
*)0)), (i)))
) == 0)
187 goto err;
188 }
189 }
190 return 1;
191
192err:
193 return 0;
194}
195
196int
197OCSP_RESPONSE_print(BIO *bp, OCSP_RESPONSE* o, unsigned long flags)
198{
199 int i, ret = 0;
200 long l;
201 OCSP_CERTID *cid = NULL((void*)0);
202 OCSP_BASICRESP *br = NULL((void*)0);
203 OCSP_RESPID *rid = NULL((void*)0);
204 OCSP_RESPDATA *rd = NULL((void*)0);
205 OCSP_CERTSTATUS *cst = NULL((void*)0);
206 OCSP_REVOKEDINFO *rev = NULL((void*)0);
207 OCSP_SINGLERESP *single = NULL((void*)0);
208 OCSP_RESPBYTES *rb = o->responseBytes;
209
210 if (BIO_puts(bp, "OCSP Response Data:\n") <= 0)
211 goto err;
212 l = ASN1_ENUMERATED_get(o->responseStatus);
213 if (BIO_printf(bp, " OCSP Response Status: %s (0x%lx)\n",
214 OCSP_response_status_str(l), l) <= 0)
215 goto err;
216 if (rb == NULL((void*)0))
217 return 1;
218 if (BIO_puts(bp, " Response Type: ") <= 0)
219 goto err;
220 if (i2a_ASN1_OBJECT(bp, rb->responseType) <= 0)
221 goto err;
222 if (OBJ_obj2nid(rb->responseType) != NID_id_pkix_OCSP_basic365) {
223 BIO_puts(bp, " (unknown response type)\n");
224 return 1;
225 }
226
227 i = ASN1_STRING_length(rb->response);
Value stored to 'i' is never read
228 if (!(br = OCSP_response_get1_basic(o)))
229 goto err;
230 rd = br->tbsResponseData;
231 l = ASN1_INTEGER_get(rd->version);
232 if (BIO_printf(bp, "\n Version: %lu (0x%lx)\n", l+1, l) <= 0)
233 goto err;
234 if (BIO_puts(bp, " Responder Id: ") <= 0)
235 goto err;
236
237 rid = rd->responderId;
238 switch (rid->type) {
239 case V_OCSP_RESPID_NAME0:
240 X509_NAME_print_ex(bp, rid->value.byName, 0, XN_FLAG_ONELINE((1 | 2 | 4 | 0x10 | 0x100 | 0x200) | 8 | (2 << 16) | (
1 << 23) | 0)
);
241 break;
242 case V_OCSP_RESPID_KEY1:
243 i2a_ASN1_STRING(bp, rid->value.byKey, V_ASN1_OCTET_STRING4);
244 break;
245 }
246
247 if (BIO_printf(bp, "\n Produced At: ")<=0)
248 goto err;
249 if (!ASN1_GENERALIZEDTIME_print(bp, rd->producedAt))
250 goto err;
251 if (BIO_printf(bp, "\n Responses:\n") <= 0)
252 goto err;
253 for (i = 0; i < sk_OCSP_SINGLERESP_num(rd->responses)sk_num(((_STACK*) (1 ? (rd->responses) : (struct stack_st_OCSP_SINGLERESP
*)0)))
; i++) {
254 if (! sk_OCSP_SINGLERESP_value(rd->responses, i)((OCSP_SINGLERESP *)sk_value(((_STACK*) (1 ? (rd->responses
) : (struct stack_st_OCSP_SINGLERESP*)0)), (i)))
)
255 continue;
256 single = sk_OCSP_SINGLERESP_value(rd->responses, i)((OCSP_SINGLERESP *)sk_value(((_STACK*) (1 ? (rd->responses
) : (struct stack_st_OCSP_SINGLERESP*)0)), (i)))
;
257 cid = single->certId;
258 if (ocsp_certid_print(bp, cid, 4) <= 0)
259 goto err;
260 cst = single->certStatus;
261 if (BIO_printf(bp, " Cert Status: %s",
262 OCSP_cert_status_str(cst->type)) <= 0)
263 goto err;
264 if (cst->type == V_OCSP_CERTSTATUS_REVOKED1) {
265 rev = cst->value.revoked;
266 if (BIO_printf(bp, "\n Revocation Time: ") <= 0)
267 goto err;
268 if (!ASN1_GENERALIZEDTIME_print(bp,
269 rev->revocationTime))
270 goto err;
271 if (rev->revocationReason) {
272 l = ASN1_ENUMERATED_get(rev->revocationReason);
273 if (BIO_printf(bp,
274 "\n Revocation Reason: %s (0x%lx)",
275 OCSP_crl_reason_str(l), l) <= 0)
276 goto err;
277 }
278 }
279 if (BIO_printf(bp, "\n This Update: ") <= 0)
280 goto err;
281 if (!ASN1_GENERALIZEDTIME_print(bp, single->thisUpdate))
282 goto err;
283 if (single->nextUpdate) {
284 if (BIO_printf(bp, "\n Next Update: ") <= 0)
285 goto err;
286 if (!ASN1_GENERALIZEDTIME_print(bp, single->nextUpdate))
287 goto err;
288 }
289 if (BIO_write(bp, "\n", 1) <= 0)
290 goto err;
291 if (!X509V3_extensions_print(bp, "Response Single Extensions",
292 single->singleExtensions, flags, 8))
293 goto err;
294 if (BIO_write(bp, "\n", 1) <= 0)
295 goto err;
296 }
297 if (!X509V3_extensions_print(bp, "Response Extensions",
298 rd->responseExtensions, flags, 4))
299 goto err;
300 if (X509_signature_print(bp, br->signatureAlgorithm, br->signature) <=
301 0)
302 goto err;
303
304 for (i = 0; i < sk_X509_num(br->certs)sk_num(((_STACK*) (1 ? (br->certs) : (struct stack_st_X509
*)0)))
; i++) {
305 X509_print(bp, sk_X509_value(br->certs, i)((X509 *)sk_value(((_STACK*) (1 ? (br->certs) : (struct stack_st_X509
*)0)), (i)))
);
306 PEM_write_bio_X509(bp, sk_X509_value(br->certs, i)((X509 *)sk_value(((_STACK*) (1 ? (br->certs) : (struct stack_st_X509
*)0)), (i)))
);
307 }
308
309 ret = 1;
310
311err:
312 OCSP_BASICRESP_free(br);
313 return ret;
314}