Bug Summary

File:src/games/boggle/mkdict/mkdict.c
Warning:line 77, column 8
Although the value stored to 'p' is used in the enclosing expression, the value is never actually read from 'p'

Annotated Source Code

Press '?' to see keyboard shortcuts

clang -cc1 -cc1 -triple amd64-unknown-openbsd7.0 -analyze -disable-free -disable-llvm-verifier -discard-value-names -main-file-name mkdict.c -analyzer-store=region -analyzer-opt-analyze-nested-blocks -analyzer-checker=core -analyzer-checker=apiModeling -analyzer-checker=unix -analyzer-checker=deadcode -analyzer-checker=security.insecureAPI.UncheckedReturn -analyzer-checker=security.insecureAPI.getpw -analyzer-checker=security.insecureAPI.gets -analyzer-checker=security.insecureAPI.mktemp -analyzer-checker=security.insecureAPI.mkstemp -analyzer-checker=security.insecureAPI.vfork -analyzer-checker=nullability.NullPassedToNonnull -analyzer-checker=nullability.NullReturnedFromNonnull -analyzer-output plist -w -setup-static-analyzer -mrelocation-model pic -pic-level 1 -pic-is-pie -mframe-pointer=all -relaxed-aliasing -fno-rounding-math -mconstructor-aliases -munwind-tables -target-cpu x86-64 -target-feature +retpoline-indirect-calls -target-feature +retpoline-indirect-branches -tune-cpu generic -debugger-tuning=gdb -fcoverage-compilation-dir=/usr/src/games/boggle/mkdict/obj -resource-dir /usr/local/lib/clang/13.0.0 -I /usr/src/games/boggle/mkdict/../boggle -internal-isystem /usr/local/lib/clang/13.0.0/include -internal-externc-isystem /usr/include -O2 -fdebug-compilation-dir=/usr/src/games/boggle/mkdict/obj -ferror-limit 19 -fwrapv -D_RET_PROTECTOR -ret-protector -fgnuc-version=4.2.1 -vectorize-loops -vectorize-slp -fno-builtin-malloc -fno-builtin-calloc -fno-builtin-realloc -fno-builtin-valloc -fno-builtin-free -fno-builtin-strdup -fno-builtin-strndup -analyzer-output=html -faddrsig -D__GCC_HAVE_DWARF2_CFI_ASM=1 -o /home/ben/Projects/vmm/scan-build/2022-01-12-194120-40624-1 -x c /usr/src/games/boggle/mkdict/mkdict.c
1/* $OpenBSD: mkdict.c,v 1.13 2016/01/07 16:00:31 tb Exp $ */
2/* $NetBSD: mkdict.c,v 1.2 1995/03/21 12:14:49 cgd Exp $ */
3
4/*-
5 * Copyright (c) 1993
6 * The Regents of the University of California. All rights reserved.
7 *
8 * This code is derived from software contributed to Berkeley by
9 * Barry Brachman.
10 *
11 * Redistribution and use in source and binary forms, with or without
12 * modification, are permitted provided that the following conditions
13 * are met:
14 * 1. Redistributions of source code must retain the above copyright
15 * notice, this list of conditions and the following disclaimer.
16 * 2. Redistributions in binary form must reproduce the above copyright
17 * notice, this list of conditions and the following disclaimer in the
18 * documentation and/or other materials provided with the distribution.
19 * 3. Neither the name of the University nor the names of its contributors
20 * may be used to endorse or promote products derived from this software
21 * without specific prior written permission.
22 *
23 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
24 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
25 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
26 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
27 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
28 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
29 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
30 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
31 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
32 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
33 * SUCH DAMAGE.
34 */
35
36/*
37 * Filter out words that:
38 * 1) Are not completely made up of lower case letters
39 * 2) Contain a 'q' not immediately followed by a 'u'
40 * 3) Are less than 3 characters long
41 * 4) Are greater than MAXWORDLEN characters long
42 */
43
44#include <ctype.h>
45#include <err.h>
46#include <limits.h>
47#include <stdio.h>
48#include <stdlib.h>
49#include <string.h>
50#include <unistd.h>
51
52#include "bog.h"
53
54int
55main(int argc, char *argv[])
56{
57 char *p, *q;
58 const char *errstr;
59 int ch, common, n, nwords;
60 int current, len, prev, qcount;
61 char buf[2][MAXWORDLEN40 + 1];
62
63 if (pledge("stdio", NULL((void *)0)) == -1)
64 err(1, "pledge");
65
66 prev = 0;
67 current = 1;
68 buf[prev][0] = '\0';
69 if (argc == 2) {
70 n = strtonum(argv[1], 1, INT_MAX2147483647, &errstr);
71 if (errstr)
72 errx(1, "%s: %s", argv[1], errstr);
73 }
74
75 for (nwords = 1;
76 fgets(buf[current], MAXWORDLEN40 + 1, stdin(&__sF[0])) != NULL((void *)0); ++nwords) {
77 if ((p = strchr(buf[current], '\n')) == NULL((void *)0)) {
Although the value stored to 'p' is used in the enclosing expression, the value is never actually read from 'p'
78 warnx("word too long: %s", buf[current]);
79 while ((ch = getc(stdin)(!__isthreaded ? (--((&__sF[0]))->_r < 0 ? __srget(
(&__sF[0])) : (int)(*((&__sF[0]))->_p++)) : (getc)
((&__sF[0])))
) != EOF(-1) && ch != '\n')
80 ;
81 if (ch == EOF(-1))
82 break;
83 continue;
84 }
85 len = 0;
86 for (p = buf[current]; *p != '\n'; p++) {
87 if (!islower((unsigned char)*p))
88 break;
89 if (*p == 'q') {
90 q = p + 1;
91 if (*q != 'u')
92 break;
93 else {
94 while ((*q = *(q + 1)))
95 q++;
96 }
97 len++;
98 }
99 len++;
100 }
101 if (*p != '\n' || len < 3 || len > MAXWORDLEN40)
102 continue;
103 if (argc == 2 && nwords % n)
104 continue;
105
106 *p = '\0';
107 p = buf[current];
108 q = buf[prev];
109 qcount = 0;
110 while ((ch = *p++) == *q++ && ch != '\0')
111 if (ch == 'q')
112 qcount++;
113 common = p - buf[current] - 1;
114 printf("%c%s", common + qcount, p - 1);
115 prev = !prev;
116 current = !current;
117 }
118 warnx("%d words", nwords);
119 return 0;
120}